spec-first/connexion

Throw an error on no operation_id

Open

#1,166 opened on Feb 21, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (738 forks)batch import
good first issue

Repository metrics

Stars
 (4,346 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://github.com/zalando/connexion/blob/96bdcb010a4e5180c2bce18295e7b576c9c1ef0f/connexion/resolver.py#L60

Currently operation_id == None flows into function_resolver and triggers unexpected errors. Better to do?:

if operation_id is None:
  raise ResolverError("operation_id is None", sys.exc_info())

Contributor guide

Research direction
Add a guard clause to raise ResolverError when operation id is None before calling function resolver.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90