sparklemotion/nokogiri

JRuby Builder throws namespace error when creating a node with a non-default namespace

Open

#1854 opened on Jan 8, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Ruby (5,615 stars) (806 forks)batch import
help wantedplatform/jrubytopic/buildertopic/namespaces

Description

If you're having trouble installing Nokogiri ...

Have you tried following the installation tutorial?

What is the output of gem install?

What are the contents of the mkmf.log file?

What operating system are you using? win10 jruby9.1.13

If this isn't an installation issue ...

What problems are you experiencing?

NAMESPACE_ERR: An attempt is made to create or change an object in a way which is incorrect with regard to namespaces.

What's the output from nokogiri -v? 1.10.0 (same problem with 1.9.1) Can you provide a self-contained script that reproduces what you're seeing? using gem AllureRubyAdaptorApi it use nokogiri

in the line : https://github.com/sparklemotion/nokogiri/blob/master/lib/nokogiri/xml/document.rb#L89

def create_element name, *args, &block
        elm = Nokogiri::XML::Element.new(name, self, &block)
        args.each do |arg|

get error just like Nokogiri::XML::Element.new('abc:def',self,&block)

the allure api gem usage is just like ::

https://github.com/allure-framework/allure-ruby-commons/blob/master/lib/allure-ruby-adaptor-api/builder.rb#L126

is that another way to create a xml node with name "ns2:test-suite"

Contributor guide

Tech stack
ruby
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Ruby basicsXML namespacesNokogiri usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the `create element` method in `lib/nokogiri/xml/document.rb` around line 89. The issue is that creating an element with a namespace prefix like 'abc:def' causes a DOM exception. Look at how `Nokogiri::XML::Element.new` handles prefixed names and whether it registers namespaces appropriately. Consider if the fix involves checking for a prefix and automatically declaring the namespace if it's not registered. Also review the Allure Ruby adapter usage at https://github.com/allure framework/allure ruby commons/blob/master/lib/allure ruby adaptor api/builder.rb#L126 for context.