sparklemotion/nokogiri

JRuby nokogiri incorrectly include xml declaration for html transformation

Open

#1430 opened on Feb 17, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Ruby (5,615 stars) (806 forks)batch import
help wantedneeds/researchplatform/jruby

Description

Using the following code:

input_xml = <<-EOS
<?xml version="1.0" encoding="utf-8"?>
<report>
  <title>My Report</title>
</report>
EOS

input_xsl = <<-EOS
<?xml version="1.0" encoding="utf-8"?>
<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
  <xsl:template match="/">
    <html>
      <head>
        <title><xsl:value-of select="report/title"/></title>
      </head>
      <body>
        <h1><xsl:value-of select="report/title"/></h1>
      </body>
    </html>
  </xsl:template>
</xsl:stylesheet>
EOS

require 'nokogiri'

xml = ::Nokogiri::XML(input_xml)
xsl = ::Nokogiri::XSLT(input_xsl)

puts xsl.apply_to(xml)

expected behavior:

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>My Report</title>
</head>
<body><h1>My Report</h1></body>
</html>

actual behavior:

<?xml version="1.0" encoding="UTF-8"?><html><head><title>My Report</title></head><body><h1>My Report</h1></body></html>

Contributor guide

Tech stack
ruby
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RubyXSLT basicsNokogiri API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Nokogiri XSLT transformation code for JRuby, specifically the method that applies XSLT to XML. Compare with the C extension implementation. Check for an option to omit XML declaration for HTML output, such as `omit xml declaration`. Review the comments on issue #1430 for any hints or previous attempts. Look at the Java extension file `ext/java/nokogiri/xslt stylesheet.java` for potential differences in handling serialization.