sous-chefs/nodejs

nodejs_npm with json is not idempotent

Open

#39 opened on Sep 17, 2014

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Ruby (188 forks)auto 404
BugPriority: Lowhacktoberfest

Repository metrics

Stars
 (228 stars)
PR merge metrics
 (PR metrics pending)

Description

Running into an issue where using the nodejs_npm lwrp with a json (packages.json) file will run 'npm install' on every converge.

nodejs_npm 'node-app-name' do
  path '/path/to/app'
  json true
  user 'bill'
  group 'bill'
  version '1.2.3'
end

it appears that the LWRP only checks the package/version/path of individual node packages, as opposed to the "name" and "version" of the json project being installed and whether or not its dependencies have been satisfied.

Contributor guide

Research direction
Examine the nodejs npm LWRP's `:install` action and understand how it determines whether to run 'npm install' when the `json` attribute is true. Then modify it to check the project's package.json name and version, and the installed dependencies, to make the resource idempotent.
Tech stack
rubynodejs
Domain
infrastructuredevops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ChefRubynpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60