sourcegraph/sourcegraph-public-snapshot

insights: replace/remove `GroupedResult` struct for compute streaming results

Open

#38,472 opened on Jul 8, 2022

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Go (1,374 forks)auto 404
backendcode-insightsdebtgood first issue

Repository metrics

Stars
 (10,290 stars)
PR merge metrics
 (PR metrics pending)

Description

PR #38416 removes deprecated code paths from the insights backend which means GroupedResult which we used for aggregating graphql results and adjacent structs are not needed anymore.

we can remove the computeTabulationResultToGroupedResults function and find a better common struct for ComputeTabulationResult, if any is needed

Contributor guide

Research direction
Examine the deprecated `GroupedResult` struct and its usage, then replace it with a common struct or remove the function.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60