sourcegraph/sourcegraph-public-snapshot

Adding LSIF to private repos as a contributor is a confusing user experience

Open

#24,457 opened on Aug 31, 2021

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Go (1,374 forks)auto 404
good first issueteam/graph

Repository metrics

Stars
 (10,290 stars)
PR merge metrics
 (PR metrics pending)

Description

Users adding LSIF to their private repos get UI errors if they're not site admins. Although being a contributor is sufficient to set up and get precise code intelligence results, the current behaviour is confusing as Sourcegraph only shows settings and upload states if the user is a site admin.

Example: User is a repo contributor, sets up LSIF for their repo and get the following errors.

Screenshot 2021-08-31 at 14 37 51 Screenshot 2021-08-31 at 14 38 05

However, LSIF config is working and they get precise code intelligence results in their repo.

Contributor guide

Research direction
Investigate the permission checks for LSIF settings and upload states. Identify where site admin only checks are performed and modify to allow contributors to see appropriate UI without errors.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75