souramoo/commentoplusplus

db files ending up in build/prod/db/db instead of build/prod/db?

Open

#39 opened on May 6, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (433 stars) (67 forks)user submission
buggood first issue

Description

Hi,

I had a weird issue upgrading this morning: I was running an older version (March 2021 I believe), which was installed by git clone'ing this repo.

This morning I did a git pull, followed by a make prod and a restart of the comment-server.

When checking the site, I saw that no comments were loaded, and when logging in, I noticed a few PostgreSQL errors on the console. I quickly determined that the last few migrations hadn't run.

I then noticed that the .sql migration files were placed in ~/commentoplusplus/build/prod/db/db, while the other (March) sql files where in ~/commentoplusplus/build/prod/db.

After I copied all .sql files from the db/db dir to the db dir, and kicked the server, everything ran.

Contributor guide

Tech stack
gopostgresql
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programming languageMakefile syntaxPostgreSQL migrations
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the Makefile and build scripts in commentoplusplus to understand why SQL migration files are placed in build/prod/db/db instead of build/prod/db. Check if there is a recursive copy or a target for db directory. Look at the prod target in Makefile and any relevant shell scripts. Ensure there is no duplicate or incorrect path. Consider adding a test to verify migration file location.
db files ending up in build/prod/db/db instead of build/prod/db? · souramoo/commentoplusplus#39 | Good First Issue