souporserious/react-view-pager

workarounds for contain={true} and onScroll progress?

Open

#49 opened on Jan 1, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (46 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (294 stars)
PR merge metrics
 (PR metrics pending)

Description

happy new year!

when contain is set to {true}, onScroll's final progress is less than expected since views no longer scroll to the very possible end...

image #1 shows that when fully scrolling to the end with contain = {false}, progress works as expected... this is when there are 7 views and viewsToShow={6}

image #2 illustrates the problem well - "Ander..." is the last view, the pager is fully scrolled, but progress remains in the 30% range because contain = {true}

before i go and see if i can hack together a math solution to the problem, is there a code-based solution that is recommended for this?

Contributor guide

Research direction
Investigate the scroll progress calculation logic in the onScroll handler when contain={true}. Compare the scroll dimensions and offset to understand why progress is capped early.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75