souporserious/react-view-pager

fix animations when viewsToShow is greater than 1

Open

#37 opened on Nov 30, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (46 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (294 stars)
PR merge metrics
 (PR metrics pending)

Description

Right now when animations are defined, the origin only works for the 1st view rather than all of the views in frame. We need to make sure the origin accounts for viewsToShow. This is the relevant line of code we need to change https://github.com/souporserious/react-view-pager/blob/master/src/Pager.js#L26

Contributor guide

Research direction
Update the origin calculation in Pager.js line 26 to account for viewsToShow so that animations apply to all visible views, not just the first one.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75