souporserious/react-motion-ui-pack

use transform attributes for SVG elements in IE

Open

#59 opened on Sep 21, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (628 stars) (40 forks)batch import
bughelp wanted

Description

Regular transforms do not work in IE. Let's check if the element is an SVG and add it directly. Could look into coordinating everything into a matrix.

Need to take transform-origin into account: http://stackoverflow.com/questions/6711610/how-to-set-transform-origin-in-svg

Maybe we can learn from Anime.js here: https://github.com/juliangarnier/anime/blob/master/anime.js#L352-L357

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React basicsSVG element transformsIE compatibility handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue is about adding transform attributes for SVG elements in IE because regular transforms do not work. The fix likely involves detecting SVG elements and applying transform attributes directly, possibly using a matrix approach. Refer to the StackOverflow link for transform origin in SVG and Anime.js implementation at lines 352-357. Investigate current React Motion code for transform handling and how IE differs. Test with IE11 or Edge legacy modes. No linked PRs or comments yet.