No exceptions thrown in async callback

Open
#83 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
32/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
api

Research direction

Start by reproducing the supplied SC.get callback snippet and trace the SC.get entry point through its asynchronous callback and error handling. Determine whether the callback exception is swallowed and define completion as preserving or clearly surfacing the exception, with a regression test for this example.

Written by the indexing model from the issue text.

Description

Experiencing some really odd stuff. Does Soundcloud suppress errors in there? if so, why?

Given this snippet:

SC.get(function(res) {
    var foo = 1
    foo.push('bar')
})

No exception is thrown. I had an actual piece of code like this and I spent at least an hour until I spotted the culprit.

Dominant language
JavaScript
Stars
388
Forks
76
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from soundcloud/soundcloud-javascript

All issues in soundcloud/soundcloud-javascript

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.