broken soundcloud auth flow - window doesn't close after authenticated
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 20/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- authentication
Research direction
Review PR #47 first, then inspect scripts/main.js at notifyDialog and connectCallback and soundcloud_auth.html, as identified by the stack trace. Confirm the authenticated SoundCloud popup closes instead of remaining on the automatic-close message across the reported browsers.
Written by the indexing model from the issue text.
Description
After authenticating with soundcloud with the popup flow, the popup never closes and just sits there with This popup should automatically close in a few seconds message. I see the following stacktrace in the console:
Uncaught TypeError: Cannot read property 'search' of undefined
at Object.notifyDialog (/scripts/main.js:97393)
at Object.connectCallback (/scripts/main.js:97386)
at soundcloud_auth.html:9
notifyDialog @ /scripts/main.js:97393
connectCallback @ /scripts/main.js:97386
(anonymous) @ soundcloud_auth.html:9
I can consistently reproduce this issue on:
- Safari: Version 10.0.1 (12602.2.14.0.7)
- Chrome: Version 55.0.2883.95 (64-bit)
- Firefox: Version 50.1.0
PR: #47 fixes this issue.
- Dominant language
- JavaScript
- Stars
- 388
- Forks
- 76
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from soundcloud/soundcloud-javascript
-
Dependency Dashboard Open
Difficulty 5/5 Over a week Newbie friendliness 15/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
soundcloud/soundcloud-javascript#90 · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
All issues in soundcloud/soundcloud-javascript
Similar issues
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
githubnext/gh-aw-workshop#3692 ·
-
agent/guide documentation hive/hosted-available-lke648397-260827-5n31
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Add: BuyPass TV Openchannels:add check:passed
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
S: triage
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
apache/cloudstack#14222 ·