SC.Connect() callback window can't close if the soundcloud App is installed on iOS

Open
#41 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
api, web-dev

Research direction

Start by reading the SC.Connect() flow and callback.html, then reproduce the iPhone 6 case with the SoundCloud app installed. Review the documented iframe workaround and its interaction with X-Frame-Options; done means the callback can close its window and return control to the original webapp.

Written by the indexing model from the issue text.

Description

(iphone 6 only)
On iOS if you have the soundcloud app installed, you can't connect soundcloud on webapps:
The app open every soundcloud urls before eventually redirecting it, thus the window.opener of callback.html represents the app and not your initial window.

http://stackoverflow.com/questions/34931556/soundcloud-js-sdk-sc-connect-callback-window-cant-close-if-app-installed-on/34952731#34952731

I Fixed it doing the auth manually and passing through an iframe to avoid the opening of the app


It seems you just set 'X-Frame-Options' to 'SAMEORIGIN', the iframe workaround is not working anynore...

Dominant language
JavaScript
Stars
388
Forks
76
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from soundcloud/soundcloud-javascript

All issues in soundcloud/soundcloud-javascript

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.