solidusio/solidus

Payment log entries are not being saved for refunds

Closed

#4,866 opened on Jan 23, 2023

View on GitHubContributor guide
 (5 comments) (0 reactions) (1 assignee)Ruby (1,270 forks)batch import
good first issuetype:bug

Repository metrics

Stars
 (4,804 stars)
PR merge metrics
 (Avg merge 6d 15h) (2 merged PRs in 30d)

Description

Apparently, refunding a payment is not creating a payment log entry when executed.

Screenshot 2023-01-23 at 16 56 05@2x

☝️ In this example, the order has been cancelled, and a payment have been automatically refunded with the credit method on the payment method/gateway. This is not attaching the log entry event to the payment.

As you can see, the refund that is correctly created for the order, is linked to the original payment, so there's no apparent reason not to link the credit log entry event to the payment:

Screenshot 2023-01-23 at 16 59 41@2x

Solidus Version: All

To Reproduce

First of all bundle exec rake sandbox and bin/rails s

  1. Complete a payment on the frontend
  2. Go to admin, capture the payment of the newly created order
  3. Refund the payment.
  4. No log entry event for the refund.

Current behavior

No log entry event logged on the original payment for its refund.

Expected behavior

A log entry event logged on the original payment for its refund.

Screenshots

See above.

Contributor guide

Research direction
Investigate the payment refund flow in Solidus, specifically the `credit` method on payment methods. Compare how log entries are created for captures versus refunds. The issue indicates that refunds do not trigger log entry creation. Examine the Payment model and related services to ensure the `credit` method also logs entries. Check the associated log entry creation code and ensure it is invoked in the refund path.
Tech stack
rubyrails
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Basic understanding of Solidus payment processing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40