solidjs-community/solid-primitives

[keyboard] Pressing Command-[key] breaks key sequences & shortcuts

Open

#553 opened on Dec 23, 2023

View on GitHubContributor guide
 (3 comments) (4 reactions) (0 assignees)TypeScript (153 forks)auto 404
help wanted

Repository metrics

Stars
 (1,541 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug

When using useKeyDownSequence and createShortcut if you at any time use a shortcut such as Command-A, they will stop working as expected. This issue can be observed on the example provided in the keyboard package's readme.

  1. Press Command + A.
  2. Observe that the A stays in "Pressed Keys".
  3. Press other keys and see they are added to the list with A. Notice the Control + E + R example does not work anymore.
  4. Blur the window and notice the A is removed. Pressing A will also remove it.

I've observed this behavior on MacOS Chrome and Safari, have not tried on Windows.

Minimal Reproduction Link

https://codesandbox.io/s/solid-primitives-keyboard-demo-s2l84k?file=/index.tsx

Contributor guide

Research direction
Investigate how the Command (Meta) key interrupts keydown sequence detection in the keyboard package. Check handleKeyDown and handleKeyUp, especially the logic for tracking pressed keys and sequence matching.
Tech stack
typescriptsolidjs
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptSolid.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70