solana-labs/solana

`solana stakes <vote pubkey>` should cleanly handle a non-vote pubkey

Open

#8441 opened on Feb 25, 2020

View on GitHub
 (13 comments) (1 reaction) (0 assignees)Rust (12,651 stars) (3,950 forks)batch import
good first issue

Description

solana stakes <identity pubkey> or solana stakes <does not exist pubkey> all silently return nothing.

Lets:

  • If possible make solana stakes <identity pubkey> report the stakes from the corresponding vote account
  • solana stakes <does not exist pubkey> report that the account was not found
  • solana stakes <some other account pubkey> report that the account is invalid

Contributor guide

Tech stack
rust
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingFamiliarity with Solana CLI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue requires modifying the `solana stakes` CLI command to handle invalid pubkeys. Start by examining the CLI source code in `cli/src/` and find the relevant command implementation. The solution should address three cases: mapping identity pubkey to vote account, reporting not found, and reporting invalid account. Check existing error handling patterns in the CLI for consistency.