solana-labs/solana

Balances are collected for transactions within a TransactionBatch that aren't locked or executed

Open

#32,346 opened on Jun 30, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (12,651 stars) (3,950 forks)batch import
communityenhancementgood first issuevalidator

Description

Problem

When collecting balances before and after execution in BankingStage, the balances for transactions within a TransactionBatch that didn't execute still get collected even though the state didn't change.

There is likely a slight performance hit for doing this, especially with batches that contain many transactions that failed to lock.

Proposed Solution

When collecting pre-balances, check the lock results and only collect pre-balances for transactions that lock successfully. When collecting post-balances, check the execution results and only collect post-balances for transactions that executed.

Contributor guide

Tech stack
rust
Domain
performanceblockchain
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustSolana BankingStageTransaction batch processing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Start by exploring the BankingStage code in the Solana repository, likely under 'runtime/src/banking stage.rs' or similar. Look for where pre balances and post balances are collected, and understand how TransactionBatches are processed. Then implement the proposed check to skip balance collection for transactions that did not lock or execute. Refer to the issue comments for any further context.