solana-labs/solana

Decouple metrics submission from RUST_LOG

Open

#15,215 opened on Feb 9, 2021

View on GitHub
 (14 comments) (6 reactions) (1 assignee)Rust (12,651 stars) (3,950 forks)batch import
good first issue

Description

Problem

It is occasionally desired to reduce text log size, but continue submitting full metrics. With metrics level taken from RUST_LOG, this is not possible.

Relevant Code

Datapoints are pushed to the MetricsAgent based on log level here: https://github.com/solana-labs/solana/blob/d4ce59eee7e2537f02c827b6918de9af559b06bd/metrics/src/datapoint.rs#L153-L165

If the datapoint has sufficient log-level based on RUST_LOG to get submitted, then it will eventually reach here where it is both logged to file and pushed into a vector to be sumitted. https://github.com/solana-labs/solana/blob/d4ce59eee7e2537f02c827b6918de9af559b06bd/metrics/src/metrics.rs#L261-L264

Proposed Solution

Look into the feasibility of decoupling metrics from RUST_LOG

Contributor guide

Tech stack
rust
Domain
observabilityperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustSolana metrics module
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the metrics submission flow in metrics/src/datapoint.rs and metrics/src/metrics.rs. Understand how datapoints are filtered by log level via RUST LOG. Explore adding a separate configuration mechanism (e.g., an environment variable) to control minimum log level for metrics independently. Review existing comments in the issue for any design constraints or rejected approaches.
Decouple metrics submission from RUST_LOG · solana-labs/solana#15215 | Good First Issue