solana-labs/solana

Would you support the "pong" response in websocket api when receiving "ping"?

Open

#15,187 opened on Feb 8, 2021

View on GitHub
 (7 comments) (3 reactions) (0 assignees)Rust (3,950 forks)batch import
good first issue

Repository metrics

Stars
 (12,651 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Problem

I connect to my own solana node via websocket, but I found It seems not provide a complete heartbeat flow (send ping then get pong). imho, a pong not only a server response, also a network performance. I can know there is something wrong via a late response time.

Proposed Solution

Just like other api do, response a struct {"jsonrpc":"2.0","result":"pong","id": 1} or something like that.

Contributor guide

Research direction
Locate the websocket ping handler in the Solana node and implement a pong response.
Tech stack
rust
Domain
blockchainapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75