solana-labs/solana

Missing invoke translation test

Open

#13955 opened on Dec 4, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (12,651 stars) (3,950 forks)batch import
good first issueruntime

Description

Problem

Missing a test that verifies the AccountInfo's data length is correctly enforced to exist in RW data. The length is translated correctly but we have no way to ensure that it will continue to do so over time.

https://github.com/solana-labs/solana/blob/5dceddd21d3c1cf874b003a0c25b1f21f4926614/programs/bpf/rust/ro_modify/src/lib.rs#L158

Proposed Solution

AccountInfo's data is expressed as an Rc<RefCell<&mut [u8]>>, need a way to construct this where the slice's len is in RO memory (like the RO segment of a BPF ELF) while the data pointer points to RW memory. This is not a use case that can be activated without malicious intent.

Contributor guide

Tech stack
rust
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
RustSolana BPFRc<RefCell>memory segments
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue requires writing a test that constructs an Rc<RefCell<&mut [u8]>> where the slice's length is in RO memory (like the RO segment of a BPF ELF) while the data pointer points to RW memory. Refer to the linked file in solana/programs/bpf/rust/ro modify/src/lib.rs for context. Investigate how to simulate this memory layout in a test environment, possibly by using unsafe code or existing testing utilities. Examine similar tests in the same repository for patterns.