solana-labs/solana

`solana vote-account` authorized-voter display is not clear

Open

#11273 opened on Jul 29, 2020

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Rust (12,651 stars) (3,950 forks)batch import
good first issue

Description

Problem

We currently display a vote account info on the CLI as follows:

$ solana vote-account vote.json
Account Balance: 0.02685864 SOL
Validator Identity: 7hguFUbg1pbkSppuwfZ1i9n9Wrqs22J4nLRepGnjvniW
Vote Authority: {2: "7hguFUbg1pbkSppuwfZ1i9n9Wrqs22J4nLRepGnjvniW"}
Withdraw Authority: 7hguFUbg1pbkSppuwfZ1i9n9Wrqs22J4nLRepGnjvniW
Credits: 0
Commission: 100%
Root Slot: ~
Recent Timestamp: BlockTimestamp { slot: 0, timestamp: 0 }

The line Vote Authority: {2: "7hguFUbg1pbkSppuwfZ1i9n9Wrqs22J4nLRepGnjvniW"} is not clear what the two values represents, which is: epoch: authorized_voter. So if you authorize a new voter, it should be reported there, keyed to the epoch it changed.

Proposed Solution

  • Change Vote Authority line to just display the pubkey of the vote auth, same format as withdraw auth.
  • Add a separate line for the epoch change data, like: Vote Authority last changed during Epoch: [epoch]

Contributor guide

Tech stack
rust
Domain
cliblockchain
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic RustFamiliarity with CLI output formatting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue describes a clear feature request to improve the CLI output of `solana vote account`. The current display shows `Vote Authority: {2: "pubkey"}` which is unclear. The proposed solution is to change it to display the pubkey directly like the withdraw authority, and add a separate line for the epoch change data. To implement, look at the CLI code responsible for displaying vote account info, likely in the Solana CLI source (e.g., `cli/src/vote.rs` or similar). Modify the formatting to match the proposed output. Check existing comments for any additional context or partial implementations.