solana-labs/solana-program-library

[spl-token]: getOrCreateAssociatedTokenAccount throws TokenAccountNotFoundError for different errors

Open

#3,326 opened on Jul 7, 2022

View on GitHub
 (11 comments) (3 reactions) (0 assignees)Rust (2,401 forks)auto 404
good first issue

Repository metrics

Stars
 (4,236 stars)
PR merge metrics
 (PR metrics pending)

Description

I noticed that when calling getOrCreateAssociatedTokenAccount, TokenAccountNotFoundError gets thrown in very different situations. I'm wondering if this can be improved to throw more specific errors?

2 specific scenarios that I found is when the payer account doesn't have enough SOL, it throws this error And also when the method takes too long, it also throws this method even though the account is created after the fact.

Contributor guide

Research direction
Investigate the getOrCreateAssociatedTokenAccount function to identify where errors from different scenarios (insufficient SOL, timeout) are incorrectly mapped to TokenAccountNotFoundError, and propose separate error types.
Tech stack
rust
Domain
blockchain
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustSolana
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60