Support function defs as function values (for factory dependencies)

Open
#43 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
scala
Domain
tooling

Research direction

The issue names no source files or tests. Start by locating MacWire's handling of function definitions and function-valued dependencies; done means a def like platformsBackend can satisfy the function-valued constructor dependency, with coverage for the shown wiring.

Written by the indexing model from the issue text.

Description

It would be nice if function defs were automatically converted to function values.

So that with the following class:

class PlatformsPage(store:PlatformStore,platformBackend:(BackendScope[Props,State] => Backend))

You could wire its dependencies with a module like:

trait PlatformsModule {
  lazy val platformsPage = wire[PlatformsPage]
  lazy val platformsStore = wire[PlatformStore]
  def platformsBackend(scope:BackendScope[Props,State]):Backend = new Backend(scope)
}

There are easy alternatives:

lazy val platformsBackend:BackendScope[Props,State] => Backend = new Backend(_)
type BackendFactory = BackendScope[Props,State] => Backend
lazy val platformsBackend:BackendFactory = new Backend(_)

But given that defs are used with MacWire, it seems like it would be nice to support function defs as function value dependencies.

Dominant language
Scala
Stars
1.3k
Forks
77
Avg merge
9m
Merged PRs (30d)
4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from softwaremill/macwire

All issues in softwaremill/macwire

Similar issues

More Scala issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.