sockeqwe/mosby

Mosby V4 - AndroidX support

Open

#339 opened on Dec 27, 2019

View on GitHub
 (10 comments) (10 reactions) (0 assignees)Java (5,495 stars) (846 forks)batch import
help wanted

Description

Unfortunately Mosby V3 is not compatable with AndroidX as accessing the backstack to see if a fragment is still in use (or presenter can be released) is not possible anymore in androidx as the method to get this information is "blacklisted" and no accessible from the outside anymore (it was in support.v4 days) see #338 #336

Any workaround suggested in #338 seems to me fragile. Therefore I considering the following: What we actually need is a lifecycle callback that tells us when the Fragment is actually destroyed. We could get this information by using AndroidX ViewModel,onCleared().

This will not be breaking change, rather it's a minor implementation detail under the hood.

What do you think?

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Android development experienceUnderstanding of ViewModel and LifecycleJava or Kotlin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Review referenced issues #338 and #336 to understand the AndroidX compatibility problem. Study Mosby V3's current fragment lifecycle handling and the Presenter release logic. Then design a solution using AndroidX ViewModel.onCleared() to detect fragment destruction, ensuring backward compatibility. The implementation should be localized to the Mosby library's internal classes, likely in the MvpFragment or related base classes.