snabbdom/snabbdom

Hook signature of create

Open

#275 opened on Apr 18, 2017

View on GitHub
 (2 comments) (3 reactions) (0 assignees)TypeScript (11,106 stars) (1,118 forks)batch import
affects:usergood first issuetype:enhancement

Description

Would you be in favor of simplifying the hook signature of create ? It takes an arbitrary emptyVnode as a first argument.

The fact that the logic is reused in the core modules for the create and update phases should not bother users everytime they want to do something in a create hook. I use this hook a lot and it's so annoying.

It would just be a matter of creating a wrapping function in the modules.

If you all agree, I'm happy to create a PR when I have some time.

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of snabbdom hooksfamiliarity with TypeScriptvirtual DOM basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the current `create` hook signature in snabbdom's core modules (e.g., `src/modules`). Understand how the `emptyVnode` argument is used and why it exists. Look at existing hook implementations to see how a wrapper could simplify the signature. Check issue comments to see if maintainers have indicated agreement. If consensus is positive, propose a concrete wrapper implementation in a new PR.