smpallen99/coherence

Decoupling controller functionality

Open

#324 opened on Jan 17, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Elixir (1,259 stars) (220 forks)batch import
enhancementhelp wanted

Description

Hey,

I'm very interested in coherence and the functionality it provides, however, I'd like to experiment with combining its functionality with other frameworks, for example ueberauth, or just in the case where I would like to use my customer controllers.

I have noticed that a lot of the meat is inside the coherence controllers, for example in order to fully create a new session you require to use Coherence.SessionController.create/2. Would it be a good idea to separate this functionality into a separate module so it could be used outside of coherence?

If this seems sensible I could start with a PR to pull out session functionality? I'm not 100% sure what the *_service.ex modules are intended for, but this would be a place I'd refactor the functionality to.

How does this sound?

Contributor guide

Tech stack
elixir
Domain
backendauthentication
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Elixir knowledgePhoenix controllers experienceCoherence codebase understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue proposes refactoring Coherence.SessionController.create/2 into a separate module. Review existing * service.ex modules to identify current patterns. Consult maintainer feedback from the single comment and examine how similar frameworks handle controller separation. Focus on extracting session logic first.