smpallen99/coherence

Resetting Password to blank possible

Open

#281 opened on Sep 18, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Elixir (220 forks)batch import
bughelp wanted

Repository metrics

Stars
 (1,259 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I found a minor inconvenience when resetting passwords via email and disabling browser form validation. There seems to be a missing validation check and just submitting the form without filling out password and password_confirm results in a lockout of the account requiring another password reset.

Another, more general question: If I were to change a underlying default controller action of Coherence how would you set something like that up? I am pretty new to elixir and i guess there is a way to replace an already defined defmodule action.

Many thanks

Contributor guide

Research direction
Inspect the password reset controller in Coherence and add validation to ensure password and password confirm fields are not blank before updating the user.
Tech stack
elixir
Domain
backendauthentication
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ElixirPhoenixCoherence
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75