smpallen99/coherence

Rememberable in last git version.

Open

#279 opened on Sep 12, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Elixir (1,259 stars) (220 forks)batch import
bughelp wanted

Description

Hello. I have two problems with rememberable in last git version.

  • If I use my own user_schema in Config, it works ok evereywhere, when is used as declared, except in Rememberable.eex Schema, when is used: belongs_to :user, Module.concat(Config.module, Config.user_schema) This is inconsistent with rest of uses, for example in controllers: defp rememberable_enabled? do if Config.user_schema.rememberable?(), do: true, else: false end Where is not concatenated with the module.

  • Second, I want to use just a Rememberable Schema (as I do with user) declaring it in Config in order to reuse the same schema in some apps. But in controllers Rememberable is obtained using Coherence.Schemas.schema(Rememberable), and not from config.

    def schema(schema) do Module.concat [Config.module, Coherence, schema] end

So I can't reuse the Rememberable schema.

Thanxs in advance.

Contributor guide

Tech stack
elixir
Domain
authenticationbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Elixir knowledgeCoherence configuration familiarityPhoenix framework basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
First, clone the coherence repository and examine lib/coherence/schemas.ex to understand how Module.concat is used for schemas. Compare it with the usage of Config.module and Config.user schema in other files like controllers. Note the inconsistency: in controllers, Config.user schema.rememberable?() is called directly without concatenation, but in Rememberable.eex Schema it uses Module.concat(Config.module, Config.user schema). Investigate how the Rememberable schema is obtained via Coherence.Schemas.schema(Rememberable) and why it doesn't use the config. The goal is to make Rememberable schema configurable and reusable. Look for existing config options like user schema and consider adding a rememberable schema option. Consult the coherence documentation and config files for patterns to follow.