slovensko-digital/priznanie-digital

Replace hardcoded 18 with MAX_CHILD_AGE_BONUS in test files

Open

#1,116 opened on Mar 28, 2026

View on GitHub
 (0 comments) (0 reactions) (1 assignee)HTML (15 forks)auto 404
good first issuehackathon

Repository metrics

Stars
 (20 stars)
PR merge metrics
 (PR metrics pending)

Description

MAX_CHILD_AGE_BONUS = 18 is already exported from src/lib/calculation.ts. The child age boundary is hardcoded as 18 in several test files. If the value ever changes, tests won't reflect it automatically. As it used to be 25 in the past, better be prepare for it.

Contributor guide

Research direction
Search for all occurrences of the number 18 in test files and replace them with the imported constant MAX CHILD AGE BONUS from src/lib/calculation.ts.
Tech stack
typescriptjavascript
Domain
testingbackend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90