slimtoolkit/slim

Refactor `--http-probe-exec` and `--http-probe-exec-file` to be separate from HTTP probes and add its own `continue-after` mode

Open

#266 opened on Dec 27, 2021

View on GitHub
 (4 comments) (1 reaction) (0 assignees)Go (17,694 stars) (673 forks)batch import
featurehelp wanted

Description

These flags represent app probes that you configure to run when docker-slim is doing dynamic analysis. It should be done separately from the existing HTTP probes.

New names: --app-exec (was --http-probe-exec) --app-exec-file (was --http-probe-exec-file)

New continue-after mode: app

Contributor guide

Tech stack
go
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
GoCLI flagsDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Identify all locations in the codebase that reference http probe exec and http probe exec file flags. Create new flags app exec and app exec file with identical behavior but separate from HTTP probe handling. Implement a new continue after mode 'app' that waits for execution of these app exec probes. Remove or deprecate the old flags and update the CLI help text, documentation, and any tests that cover these flags. The relevant files are likely in the cmd/ and pkg/ directories of the repository.