test: unit test flakes for activity logs stream
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- go
- Domain
- cli, testing-qa
Research direction
Start with internal/pkg/platform/activity_test.go around lines 249-269 and run the TestPlatformActivity_StreamingLogs case from the linked Actions failure. Investigate the polling timing behind the mismatch between the expected three Activity calls and the actual four, then verify the test reliably covers the request-failure behavior without flaking.
Written by the indexing model from the issue text.
Description
Summary
A recent test run on main failed for reasons unrelated to the recent commit. Perhaps a timing of a poll?
The retry succeeded! 🧪 ✨
Preview
🔗 https://github.com/slackapi/slack-cli/actions/runs/23178071163/job/67344594805
=== RUN TestPlatformActivity_StreamingLogs/should_return_nil_if_TailArg_is_set_and_activity_request_fails_while_polling
activity_test.go:267:
Error Trace: /Users/runner/work/slack-cli/slack-cli/internal/pkg/platform/activity_test.go:267
/Users/runner/work/slack-cli/slack-cli/internal/pkg/platform/activity_test.go:296
Error: Not equal:
expected: 3
actual : 4
Test: TestPlatformActivity_StreamingLogs/should_return_nil_if_TailArg_is_set_and_activity_request_fails_while_polling
Messages: Expected number of calls (3) of method Activity does not match the actual number of calls (4).
- Dominant language
- Go
- Stars
- 305
- Forks
- 46
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 23
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from slackapi/slack-cli
-
Installer aborts on an existing same-named `slack` binary; prefer install + warning over hard abort Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
bug build release
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
area:bolt-python bug
Difficulty 3/5 1-2 days Newbie friendliness 55/100
-
build code health
Difficulty 3/5 1-2 days Newbie friendliness 55/100
-
enhancement semver:minor
Difficulty 5/5 Over a week Newbie friendliness 25/100
All issues in slackapi/slack-cli
Similar issues
-
bug github_actions
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
registrystack/registry-stack#1393 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
JakeChampion/lang#10213 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
oasisprotocol/oasis-sdk#2523 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100