Add option to disable raising exceptions on failed Slack responses or HTTP errors

Open
#178 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
28/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
ruby
Domain
api, backend

Research direction

Start by locating the Slack response and HTTP error-handling entry points in the gem and review how failed responses currently raise exceptions. Clarify the desired return values and option scope before changing behavior, then add coverage showing the configured response for both Slack failures and HTTP errors.

Written by the indexing model from the issue text.

Description

new feature

I have noticed a lot of output responses that could be slightly more helpful. In this case ideally it would be nice to receive the error class or false. It seems like a lot of times in this gem exceptions are also raised unnecessarily when a true or false response could be given.
screen shot 2017-11-14 at 4 49 41 pm

Here is another case where there could be some confusion as well and a standard language idiom could be followed.

screen shot 2017-11-14 at 4 54 58 pm
Dominant language
Ruby
Stars
1.3k
Forks
222
Avg merge
1d 14h
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from slack-ruby/slack-ruby-client

All issues in slack-ruby/slack-ruby-client

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.