skpm/sketch-module-web-view

`titleBarStyle: "hidden"` produces the same result as `"hiddenInset"`

Open

#147 opened on Mar 29, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (63 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (290 stars)
PR merge metrics
 (PR metrics pending)

Description

Setting BrowserWindow's titleBarStyle to hidden, produces the same result as hiddenInset.

The expected result should be the traffic light buttons being placed in the same position as if using default, not slightly more inset.

Reproduced in version 3.4.1

Package hidden hiddenInset
Electron ✅Expected
SMWV ❌Result

Contributor guide

Research direction
Examine the implementation of titleBarStyle in the web view module and compare with Electron's expected behavior for 'hidden' and 'hiddenInset'.
Tech stack
javascript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60