skpm/sketch-module-web-view

Get a callback with the result from `sendToWebView`

Open

#131 opened on Oct 27, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (63 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (290 stars)
PR merge metrics
 (PR metrics pending)

Description

Is there any reliable way to call a javascript function on the web view and get a callback with the result after? I don't have access to webContents in my case, because I am communicating with the web view from another command. I have tried a few things using getWebview() or accessing the thread dictionary directly, but mostly been causing Sketch to crash and still failing to get a response using .then().

Is there any recommended way using sendToWebview()?

Contributor guide

Research direction
Investigate the existing sendToWebView implementation in the skpm/sketch module web view source code. Look for how messages are sent and received. Consider using a promise based approach with a unique callback ID stored in a map. When the webview responds, call the appropriate callback. Also check if there is an existing mechanism like evaluateJavaScript that returns a promise.
Tech stack
javascript
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptSketch plugin development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40