CI: build against the declared MSRV (1.88)

Open Beginner friendly
#8 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Quiet
Tech stack
github-actions, rust
Domain
build-system, ci-cd

Research direction

Start by locating the CI workflow's pinned stable toolchain jobs and the rust-version comment in Cargo.toml. Add a workspace build-and-test job using Rust 1.88 with --locked, then confirm the workflow runs successfully and update the comment to mention lopdf, time, and weezl.

Written by the indexing model from the issue text.

Description

Problem

Cargo.toml declares rust-version = "1.88", derived from the dependency graph (lopdf 0.44.0, and transitively time / weezl, all declare 1.88). Nothing in CI builds with that compiler, so a future code change or dependency bump could silently raise the real floor above the declared one.

Proposed fix

Add a CI job that builds and tests the workspace with Rust 1.88 (dtolnay/rust-toolchain@1.88 or equivalent), alongside the pinned stable toolchain jobs. Locked dependencies (--locked) so the check reflects the shipped Cargo.lock.

While at it, extend the rust-version comment in Cargo.toml to mention that time and weezl also declare 1.88 (currently it cites lopdf only; the conclusion is unchanged).

Dominant language
Rust
Stars
0
Forks
0
Avg merge
1d 7h
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from skoji/shellac

All issues in skoji/shellac

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.