Downgrade checks to a warning and not a hard fail
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- python
- Domain
- cli, infrastructure
Research direction
Start at the restore command's PREINSTALL checks and locate the swap check that reports the expected and actual memory values. Confirm the desired behavior for insufficient swap, then make the check produce a warning rather than aborting restore, and verify that the restore operation continues.
Written by the indexing model from the issue text.
Description
We make certain hardware / base os design decisions, one of them is swap - we don't want it on any of our machines. We order more RAM if we need more memory and we don't do swap or we do it relatively small. This failed on me today:
root@c01:~/backups# skale node restore /root/backups/skale-node-backup-2023-05-22-03-39-16.tar.gz /root/.env
2023-05-23 12:05:22,719 - INFO - Adding BACKUP_RUN to env ...
2023-05-23 12:05:22,720 - INFO - Unpacking backup archive...
2023-05-23 12:05:25,377 - INFO - Executing checks. Type: CheckType.PREINSTALL
2023-05-23 12:05:26,113 - INFO - Host is not fully meet the requirements
==================== Failed checks ====================
+-------+---------------------------------------------+
| Check | Info |
+=======+=============================================+
| swap | Expected swap memory 14.9 GB, actual 1.0 GB |
+-------+---------------------------------------------+
Command failed with following errors:
--------------------------------------------------
Restore operation failed
--------------------------------------------------
You can find more info in /root/.skale/.skale-cli-log/debug-node-cli.log
This is against our own design decisions of infrastructure and there is no way to workaround it via cli option or env-file settings.
- Dominant language
- Python
- Stars
- 21
- Forks
- 7
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 5
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from skalenetwork/node-cli
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
skalenetwork/node-cli#842 ·
-
skalenetwork/node-cli#946 · 1 assignee ·
-
skalenetwork/node-cli#941 · 2 comments · 1 assignee ·
-
fair-node
skalenetwork/node-cli#938 · 1 assignee ·
-
skalenetwork/node-cli#934 · 1 assignee ·
All issues in skalenetwork/node-cli
Similar issues
-
documentation help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
simonw/sqlite-utils#872 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100