sinonjs/sinon

Use knip instead of unimported

Open

#2637 opened on Feb 10, 2025

View on GitHub
 (2 comments) (0 reactions) (1 assignee)JavaScript (9,548 stars) (764 forks)batch import
Help wantedgood first issue

Description

In https://github.com/sinonjs/sinon/pull/2636 we removed unimported, because it had been archived.

The author recommends using knip instead.

Let's implement knip and use it for finding unused files and dependencies.

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingbuild system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsJavaScriptsinon project structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Review PR #2636 for context on the previous unimported setup. Create a knip configuration file (e.g., knip.json) and add a npm script to run knip. Update the project's CI configuration if needed to include knip checks.