Run in child process instead of lazy loading every dependency · sindresorhus/update-notifier#210

(4 comments) (0 reactions) (0 assignees)JavaScript (1,800 stars) (164 forks)user submission

enhancementhelp wanted

Description

Not a big fan [of lazy loading], but I've seen update-notifier as a require time offender when profiling various things. The idea of update-notifier is that it should have no impact on the consumer. It's just an added bonus, not critical. https://github.com/yeoman/update-notifier/pull/82#issuecomment-225636213

I may be wrong, it seems to me that this change was made simply to hide the package from the very initial load but in practice every dependency is still loaded right after.

update-notifier already uses a child process to do the checking, so I think it'd be best to do the whole thing there.

Tech stack: javascriptnodejs
Domain: cliperformance
Issue type: performance
Difficulty: 3
Estimated time: half day
Activity status: fresh
Clarity: clear
Prerequisites: Node.js child processesupdate notifier internals
Newbie friendliness: 65
Research direction: Review the current implementation in index.js, especially the child process call at line 98. Understand how lazy loading currently works by examining the require statements. Then, design a solution where the entire update check logic runs in a child process, so dependencies are not loaded in the main process. Consider testing and edge cases.

Description

Contributor guide