sindresorhus/update-notifier

Bad advice when using npx

Open

#112 opened on Jun 12, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (164 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (1,800 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In this example, npx is using the locally-installed version of bower (node_modules/.bin/bower). update-notifier is correctly noticing that we're not using the latest version, but it suggests that npm i -g bower will fix that, which it will not, since it'll still use the locally-installed version, which is old.

pasted image at 2017_06_12 03_26 pm

=> $ npm -v
5.0.3
=> $ node -v
v6.9.5
=> $ npx -v
4.0.3

Contributor guide

Research direction
Examine the code that constructs the update message in update notifier. Identify where it checks for npx usage and adjust the logic to suggest updating the local package instead of the global one when npx is used.
Tech stack
javascript
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70