sindresorhus/type-fest

`PartialDeep` make `Date` internal structure partial

Open

#719 opened on Oct 20, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (12,328 stars) (471 forks)batch import
buggood first issuehelp wanted

Description

I've noticed that when you apply PartialDeep to something containing Date it makes the Date internal structure partial, which causes some errors when combining it with zod validations for instance.

Should it skip internal JS classes like Date while making something partially deep?

I've found https://github.com/sindresorhus/type-fest/pull/342, but I still see the issue on version v4.4.0, might be a regression?

Contributor guide

Tech stack
typescript
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScript type systemdeep partial types
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the implementation of `PartialDeep` in `source/partial deep.ts` and how it handles `Date` objects. Refer to the referenced PR #342 which attempted to address this issue. Check if the current behavior is a regression and consider adding a condition to skip built in types like `Date` when applying deep partial.
`PartialDeep` make `Date` internal structure partial · sindresorhus/type-fest#719 | Good First Issue