sindresorhus/strict-import

Add an option to allow certain modules to search upwards

Open

#2 opened on May 24, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (94 stars) (2 forks)user submission
enhancementhelp wanted

Description

I had the need to allow a specific module to require upwards, so I added a private option _allowedMethods in https://github.com/sindresorhus/strict-import/commit/64ac0d0530d5fe0f35bf33665f8e3ad16da6beb5. I made it private because I'm not totally happy with it. It only works for top-level imports. So you can allow require('a') to be searched upwards by including a in the option, but if a imports a module name b, there's no way to allow b specifically, other than allowing any module from a.

Context: https://github.com/lukechilds/hyperdex/commit/d54a47c921e053620a76c57c9e3534f4f2dbe42e

Contributor guide

Tech stack
javascriptnodejs
Domain
backendtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Node.js requireJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the provided commit (64ac0d0530d5fe0f35bf33665f8e3ad16da6beb5) to understand the existing private option ` allowedMethods` and its limitations in handling nested imports. Investigate the hyperdex commit (d54a47c921e053620a76c57c9e3534f4f2dbe42e) for context on the need for upward search. Then design a public API that allows specifying allowed module names with control over scope (e.g., top level only vs recursive). Consider existing tests and the module's architecture to integrate the feature.
Add an option to allow certain modules to search upwards · sindresorhus/strict-import#2 | Good First Issue