sindresorhus/sort-on

Add the ability to sort boolean values

Open

#18 opened on Mar 21, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (200 stars) (14 forks)user submission
enhancementhelp wanted

Description

Currently, invoking:

sortOn([{x: true}, {x: false}], 'x')

Is returning:

[{x: true}, {x: false}]

It would be nice to return the following instead:

[{x: false}, {x: true}]

Cheers! 😄

Contributor guide

Tech stack
javascript
Domain
developer experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine the source code of sort on, specifically the comparator logic in src/index.js. Add a check for boolean values to ensure they are sorted as false < true. Update existing tests or add new ones to cover boolean sorting. Consider edge cases like mixed arrays.