sindresorhus/recycle-bin

By default, don't permanently delete when recycle bin doesn't exist

Open

#8 opened on Dec 18, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C (71 stars) (9 forks)user submission
enhancementhelp wanted

Description

I think that's a better default. We can add a flag to get back the old behavior.

It seems like we can use the FOF_WANTNUKEWARNING flag for this:

Send a warning if a file or folder is being destroyed during a delete operation rather than recycled. This flag partially overrides FOF_NOCONFIRMATION. - https://docs.microsoft.com/en-us/windows/win32/api/shobjidl_core/nf-shobjidl_core-ifileoperation-setoperationflags

It's not immediately clear what they mean by warning and how we could check for that though.

Contributor guide

Tech stack
c
Domain
desktopcli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Windows APIC programmingWindows recycle bin concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the current implementation in the C code (likely using IFileOperation). Determine how to add the FOF WANTNUKEWARNING flag conditionally. Test on a system without a recycle bin (e.g., network drives) to verify behavior. The issue suggests adding a flag to retain old behavior, so consider a command line option.