Only show new notifications after activation? · sindresorhus/notifier-for-github#273

(0 comments) (0 reactions) (0 assignees)JavaScript (1,965 stars) (144 forks)user submission

bugenhancementhelp wanted

Description

I'm trying GH notifications for the first time (~7k unread), quickly found this extension (❤️), and was a bit amused that it seems to be showing desktop alerts for a large number of existing notifications! Looking at the code, I guess it might cap the alerts at 100, but I had to turn it off until I can get the list under control.

Is there any possibility to filter either alerts or unread count by extension activation time? If I'm following the code correctly, it seems like you are already using the Last-Modified filter to only get latest notifications when polling, so perhaps the very first poll could use "since current time" or "time - 30 minutes". Thanks for your consideration (and for making the extension).

Contributor guide

Tech stack: javascripthtmlcss
Domain: frontenddeveloper experience
Issue type: feature
Difficulty: 3
Estimated time: 1-3 hours
Activity status: fresh
Clarity: mostly clear
Prerequisites: GitHub APIbrowser extension development
Newbie friendliness: 70
Research direction: The issue requests filtering notifications shown by the extension based on activation time. Currently, the code uses Last Modified for polling but shows existing notifications on first load. To implement, modify the initial fetch to include a 'since' parameter (e.g., time of activation minus 30 minutes). Relevant files include background.js or similar where notification fetching occurs. See comments in the issue for further clarification.