sindresorhus/notifier-for-github

Notifier stays offline despite regaining connection

Open

#132 opened on Jun 8, 2017

View on GitHub
 (12 comments) (3 reactions) (0 assignees)JavaScript (1,965 stars) (144 forks)user submission
:dollar: Funded on Issuehuntbughelp wanted

Description

When Chrome goes offline and the extension looses connection to Github, it shows a yellow text bubble saying off (or something similar). When you regain internet connection, this bubble stays in place and the only way to reconnect is to manually click on the plugin icon. I have had the plugin be in 'offline' mode for long periods of time and therefore missed notifications.

Ideally, the plugin would re-connect itself and not require the user to click on the plugin icon to reconnect to Github. Not very familiar with the Chrome API but if it does not expose a method to be notified upon regaining internet connection, something like a setTimeout that pings the URL every 5 seconds until a connection could be another solution.

@sindresorhus Any thoughts? I will create a PR if you will accept it.

Backers (Total: $40.00)

Submitted pull Requests

Become a backer now!

Or submit a pull request to get the deposits!

Tips

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Chrome extension developmentJavaScriptGitHub API knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the background script (likely background.js) to understand how the offline badge is set. Implement an event listener for the 'online' window event to automatically reinitialize the connection, or add a periodic ping to the GitHub API until successful. Check linked PRs #313 and #314 for prior attempts. Test using Chrome's offline mode.