sindresorhus/linkify-urls

Parentheses in URLs break linkifying

Open

#28 opened on Nov 7, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (173 stars) (23 forks)user submission
bughelp wanted

Description

@fregante edit: Issue transferred from refined-github. This issue still happens in v3.1.0

See this line:

The URL contains parentheses which make the anchor cut off the URL in both the href and the visual link producing a wrong URL.

Original valid URL:

https://github.com/jserz/js_piece/blob/master/DOM/ParentNode/append()/append().md

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic regex knowledgeJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the current regex pattern used in the linkify urls library (likely in index.js) that fails to include parentheses in URLs. Look at the examples provided in the issue, such as 'https://github.com/jserz/js piece/blob/master/DOM/ParentNode/append()/append().md', to understand the failing case. The fix may involve modifying the regex to allow parentheses or escaping them properly. Check if any PRs or comments suggest a solution.