sindresorhus/globals

Copy missing globals from `builtin` to `es*`

Open

#140 opened on Aug 28, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (587 stars) (132 forks)user submission
enhancementhelp wanted

Description

While investigating why eslint wouldn't pick up the BigInt globals, I noticed eslint does not use builtin like I previously assumed. I'd like to propose to copy any globals missing in either es5, es2015, es2017 but present in builtin to one of those respective environments.

Afterwards, I'd copy back any potential globals from the es* categories to builtin so that it ends up containing all globals from those categories. Alternatively, builtincould be generated dynamically in index.js, I think actually, that'd be my preference to avoid future inconsistency.

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScript basicsKnowledge of ES5/ES2015/ES2017 globalsFamiliarity with the globals package structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
First, examine the current globals definitions in the repository (likely in globals.json or similar files) to understand the structure of `builtin`, `es5`, `es2015`, and `es2017`. Compare the sets to identify missing globals. Then, review the issue comments for any proposed approaches, particularly the suggestion to generate `builtin` dynamically. The implementation could involve writing a script to copy and synchronize globals, ensuring consistency. Finally, consider testing the changes with ESLint to verify that globals like `BigInt` are correctly recognized.