sindresorhus/execa

Attach `.nodeChildProcess` to the execa promise

Closed

#413 opened on Feb 16, 2020

View on GitHubContributor guide
 (13 comments) (1 reaction) (0 assignees)JavaScript (219 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (6,091 stars)
PR merge metrics
 (Avg merge 6d 18h) (6 merged PRs in 30d)

Description

Node.js does this now for childProcess. when you promisify it.

https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback

The name is to be decided.

One day, I hope we can get rid of execa() being both a childProcess and promise and just have the .child property on the promise. But that's a huge breaking change. For now, the best we can do is to add it, and recommend new users to use it instead of the old way. We could even un-document the old way.

@ehmicky Thoughts?

Contributor guide

Research direction
Investigate Node.js child process.exec promisified API to understand the `.child` property, then examine execa's current promise structure to determine how to attach a `.child` property without breaking existing behavior.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Node.jsJavaScriptPromises
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60