sindresorhus/eslint-plugin-unicorn

Create a better `prefer-template` rule

Open

#78 opened on Jan 10, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (5,022 stars) (468 forks)user submission
help wantednew rule

Description

As usual the built-in one is flawed and as usual the ESLint team refuses to acknowledge that. Luckily we can just build something better. Ref: https://github.com/eslint/eslint/issues/6572#issuecomment-229927387

Contributor guide

Tech stack
javascript
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
JavaScriptESLint rule developmentunderstanding of template literal usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the referenced ESLint issue (https://github.com/eslint/eslint/issues/6572#issuecomment 229927387) to understand the flaws in the built in `prefer template` rule. Review the current `prefer template` rule implementation in ESLint's source. Then, look at existing rules in eslint plugin unicorn to understand the plugin's style and conventions. Propose the new rule's logic and provide a proof of concept implementation. The issue does not specify exact expected behavior, so scope definition is needed.