sindresorhus/eslint-plugin-unicorn

`require-module-attributes`: Support `TSImportType`

Open

#2,726 opened on Sep 1, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,022 stars) (468 forks)user submission
change requestgood for beginnerhelp wanted

Description

Description

It seems typescript doesn't allow

type A = import("foo", {})

But allows

type A = import("foo", {with: {}})

I didn't add support for it in #2725, if someone need it, it can reuse the same logic as ImportExpression

Examples

// ❌
type A = import("foo", {with: {}})

// ✅
type A = import("foo")

Additional Info

No response

Contributor guide

Tech stack
typescriptjavascript
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScript AST knowledgeESLint rule developmentReading PR #2725
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Review the existing implementation of `require module attributes` rule and the changes made in PR #2725 for `ImportExpression`. The logic for handling `TSImportType` should mirror that of `ImportExpression` but adapted for type only imports. Focus on files like `rules/require module attributes.js` and look for how `ImportExpression` is handled. The issue provides clear examples of what should be flagged and what should be allowed.
`require-module-attributes`: Support `TSImportType` · sindresorhus/eslint-plugin-unicorn#2726 | Good First Issue